Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm_{6,7}: enable BPF target, fix bcc #53920

Merged
merged 2 commits into from Jan 14, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 14, 2019

Motivation for this change

Note sure if other bits benefit from this target as well,
but BCC is useful! O:)

cc #53907

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 14, 2019 via email

@Ericson2314
Copy link
Member

And yes, the concept seems fine to me :) though I don't even know what this bcc is!

@Mic92
Copy link
Member

Mic92 commented Jan 14, 2019

I am all for bcc to work! Great performance/debugging toolbox.

@Mic92 Mic92 closed this Jan 14, 2019
@Mic92 Mic92 merged commit f64843f into NixOS:staging Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants