Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is done in two ways:
The first timing is to track a specific event which might be the cause of our spurious failures in tests. That is, the
alarm 300
might be too conservative on the build servers. Without data we cannot know.The second part is to help track down issues in tests, hopefully tracking down whatever increase in time happened. The time was added as a log line at the end of the nest since there seems to be no way (with the current implementation) to add it as an attribute to the nest tag, since the XML writer thing seems to be made that way; we would have to defer writing the log until the nesting was closed. This should be generally machine-parseable, but I'm not entirely confident whether it should be implemented in another way to allow machine parsing.
Screenshot
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)