Fix: Replace duplicate town name "Huacho" #7038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you pick a random Spanish town name that's not already on the Spanish town name list to replace the second "Huacho"? |
Huacho appears twice in the Spanish town names list. This change removes the second one, and replaces it with a new one: Medellin.
nikolas
force-pushed
the
remove-dup-town-name
branch
from
961b89e
to
d973191
Compare
|
Good idea! That's a better solution - I've replaced it with Medellín. That will have a lot less effect on existing savegames. |
nikolas
changed the title
andythenorth
approved these changes
Jan 12, 2019
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
Huacho appears twice in the Spanish town names list. This change removes the second one, and replaces it with a new one: Medellin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huacho appears twice in the Spanish town names list. This change removes
the second one.
This will have the effect of altering many town names in any older
savegame using Latin American town names. I think that's an
acceptable side effect for a new OpenTTD release, but if you have a
better solution let me know. Maybe some type of null "Dummy" value here?