nixos: allow customizing the kernel RANDSTRUCT seed #53826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nit: Exposing such a specialized feature in the general interface may seem a little ad-hoc. |
joachifm
reviewed
Jan 12, 2019
| @@ -67,6 +68,19 @@ in | |||
| description = "A list of additional patches to apply to the kernel."; | |||
| }; | |||
|
|
|||
| boot.kernel.randstructSeed = mkOption { | |||
| type = types.str; | |||
There was a problem hiding this comment.
It'd be neat to be able to read the seed from a file instead (e.g., if I want to share my config but not the seed)
|
If you don't want to create a new module, there's |
danbst
reviewed
Jan 21, 2019
delroth
force-pushed
the
randstruct-custom-seed
branch
from
0fd0d3a
to
8769d2d
Compare
|
@GrahamcOfBorg build linux_latest_hardened linux linux_latest |
|
@GrahamcOfBorg test hardened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See #53592. RANDSTRUCT is designed to make kernel exploitation harder through diversification of the builds. Allowing users to set their own RANDSTRUCT seed differentiates their kernel build from the rest of the NixOS hardened users. In a multi-host deployment this can also be used to deploy differently seeded builds on each machine.
I was torn on whether to put this in boot/kernel.nix or create a new module in security/ for the option -- in the end I decided on boot/kernel.nix because it makes the implementation much simpler, but I'm definitely open to the "new module" option too if someone has a strong opinion about this.
Still a NixOS noob, not sure if this is the right way to do things. Let me know!
@joachifm @NeQuissimus fyi
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)