Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-fetch-remote: an overlay to fetch on remote builders #53934

Merged
merged 1 commit into from Jan 21, 2019
Merged

prefer-fetch-remote: an overlay to fetch on remote builders #53934

merged 1 commit into from Jan 21, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 14, 2019 •
edited

This is useful when running tools like NixOps or nix-review
on workstations where the upload to the builder is significantly
slower then downloading the source on the builder itself.

Motivation for this change

My parents have pretty slow internet / On crowded conferences I still want to review pull requests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jan 14, 2019

cc @andir

@Mic92 Mic92 force-pushed the prefer-fetch-remote branch 2 times, most recently from 8956f03 to ca7f958 Compare January 14, 2019 22:11
Mic92 added a commit to Mic92/nixpkgs-review that referenced this pull request Jan 16, 2019
@Mic92
factor out overlay into its own class
ac34c11 
In future this will contain NixOS/nixpkgs#53934
@Mic92
prefer-fetch-remote: an overlay to fetch on remote builders
eac6797 
This is useful when running tools like NixOps or nix-review
on workstations where the upload to the builder is significantly
slower then downloading the source on the builder itself.
@Mic92
Copy link
Member Author

Mic92 commented Jan 18, 2019

Documentation added.

@Mic92 Mic92 merged commit 86ef9a7 into NixOS:master Jan 21, 2019
@Mic92 Mic92 deleted the prefer-fetch-remote branch January 21, 2019 10:48
@Mic92 Mic92 mentioned this pull request Jan 21, 2019
Merged
10 tasks
Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Jan 21, 2019
@Mic92
nix-review: 1.0.2 -> 1.0.4
f6d6e5d 
- also accept the full url of pull request i.e.
  NixOS#54323
- stream-parse nix-env's eval output
- fix logs for failed builds issued by remote builders
- prepare code for overlays like: NixOS#53934
Mic92 added a commit that referenced this pull request Mar 22, 2019
@Mic92
nix-review: 1.0.2 -> 1.0.4
0664a06 
- also accept the full url of pull request i.e.
  #54323
- stream-parse nix-env's eval output
- fix logs for failed builds issued by remote builders
- prepare code for overlays like: #53934

(cherry picked from commit f6d6e5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
6.topic: fetch 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @worldofpeace @GrahamcOfBorg