Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

midisheetmusic: put timidity in PATH also #53813

Closed
wants to merge 0 commits into from
Closed

midisheetmusic: put timidity in PATH also #53813

wants to merge 0 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2019

Motivation for this change

Fixes issue with not finding timidity each time after NixOS update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jan 13, 2019 •
edited

It's already substituted in place. If that doesn't seem to work, I think it's better to investigate first. Also, adding it to LD_LIBRARY_PATH?

@ghost
Copy link
Author

ghost commented Jan 13, 2019

@FRidh I haven't found a better way to fix that.

LD_LIBRARY_PATH

It calls timidity binary only.

@FRidh
Copy link
Member

FRidh commented Jan 13, 2019

Then why add it to LD_LIBRARY_PATH?

@ghost
Copy link
Author

ghost commented Jan 13, 2019

@FRidh Sorry, that's indeed wrong. Will look into it.

@ghost
Copy link
Author

ghost commented Jan 16, 2019

@FRidh I don't truly understand what happens here. Sometimes if I run software it says it can't find timidity, however if I do nix-build --check, it says
error: derivation '/nix/store/kja102pfzxg8gq74zfbxbjpbw32fv6lm-midisheetmusic-2.6.drv' may not be deterministic: output '/nix/store/lj56zh0g55gywvjnxh114js3hbk45qgl-midisheetmusic-2.6' differs
and resulted software is able to find timidity O_o

@ghost ghost closed this Jan 16, 2019
@ghost
Copy link
Author

ghost commented Jan 16, 2019

Whoops deleting commit made this PR auto-closed

@ghost ghost deleted the midisheetmusic branch January 27, 2019 06:33
@ghost ghost mentioned this pull request Jun 12, 2019
Merged
10 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @GrahamcOfBorg