Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alertmanager: Allow the definition of extra options on commandline #53877

Merged
merged 1 commit into from Jan 13, 2019
Merged

Alertmanager: Allow the definition of extra options on commandline #53877

merged 1 commit into from Jan 13, 2019

Conversation

tomfitzhenry
Copy link
Contributor

I stumbled upon an issue with the Alertmanager that required
an additional comand line option. See https://groups.google.com/forum/#!msg/prometheus-users/-5wd-P13xCI/lGLBHHgnBgAJ

(cherry picked from commit 69e4e49)

Without this, Nixos machines on 18.09 that have no private IP addresses cannot start Alertmanager.
#46068
#45302

Motivation for this change

I am trying to start Alertmanager on my machine, which does not have a private IP address (only a public IP address, and localhost). As described in #46068 , to do this requires setting --cluster.advertise-address, otherwise Prometheus fails to start.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I stumbled upon an issue with the Alertmanager that required
an additional comand line option. See https://groups.google.com/forum/#!msg/prometheus-users/-5wd-P13xCI/lGLBHHgnBgAJ

(cherry picked from commit 69e4e49)

Without this, Nixos machines on 18.09 that have no private IP addresses cannot start Alertmanager.
#46068
#45302
@tomfitzhenry tomfitzhenry changed the title Allow the definition of extra options on commandline Alertmanager: Allow the definition of extra options on commandline Jan 13, 2019
@samueldr samueldr merged commit 0352694 into NixOS:release-18.09 Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants