Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synergy: fix compilation on macOS #53805

Merged
merged 1 commit into from Jan 23, 2019
Merged

synergy: fix compilation on macOS #53805

merged 1 commit into from Jan 23, 2019

Conversation

mroi
Copy link
Contributor

@mroi mroi commented Jan 11, 2019

Synergy currently does not build on macOS Mojave. Adding cf-private to the build inputs fixes the problem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mroi
synergy: fix compilation on macOS
f84e353 
cf-private is needed to build on macOS
@matthewbauer matthewbauer merged commit 8449cc5 into NixOS:master Jan 23, 2019
@mroi mroi deleted the patch-1 branch January 24, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mroi @matthewbauer @GrahamcOfBorg