Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.tinycss: fix build #53831

Merged
merged 1 commit into from Jan 12, 2019
Merged

python3.pkgs.tinycss: fix build #53831

merged 1 commit into from Jan 12, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 12, 2019

Motivation for this change

The build was broken by the python 3.7 switch, which caused an
incompatible change in the way cython generates files:

Kozea/tinycss#17

This is solved by removing the pre-generated file and re-generating it
at build time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
python3.pkgs.tinycss: fix build
934fabf 
The build was broken by the python 3.7 switch, which caused an
incompatible change in the way cython generates files:

Kozea/tinycss#17

This is solved by removing the pre-generated file and re-generating it
at build time.
@timokau timokau requested a review from FRidh as a code owner January 12, 2019 10:07
@timokau
Copy link
Member Author

timokau commented Jan 12, 2019

@GrahamcOfBorg build python2.pkgs.tinycss python3.pkgs.tinycss

@dotlambda dotlambda merged commit 6359e9b into NixOS:master Jan 12, 2019
@timokau timokau deleted the tinycss-fix branch January 12, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg