Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ugarit: fix build by using chicken-4.x #53854

Merged
merged 1 commit into from Feb 19, 2020

Conversation

evhan
Copy link
Contributor

@evhan evhan commented Jan 12, 2019

Ugarit only works with CHICKEN 4, not CHICKEN 5 (which is the version in nixpkgs since 69ef070), so use the egg tools from chicken-4 for ugarit and ugarit-manifest-maker.

Motivation for this change

The ugarit and ugarit-manifest-maker packages are broken since they're building with the wrong version of the CHICKEN compiler and libraries.

Things done

Pass the CHICKEN 4 versions of eggDerivation and fetchegg to those two packages explicitly so that they build and install with the right compiler/runtime/dependency sources.

Store size check isn't really applicable since the build was broken before, but here's the after:

/nix/store/v35vaww3312p6i5zgrdmn77hx2xaspsi-chicken-ugarit-2.0    243735720
/nix/store/hh96kdqy99w80j1x0vq62vd8glbkmgi8-chicken-ugarit-manifest-maker-0.1     241374104
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ugarit only works with CHICKEN 4, not CHICKEN 5 (which is the default
version in nixpkgs since 69ef070), so use the compiler and egg tools
from `chickenPackages_4` for ugarit and ugarit-manifest-maker.
@evhan
Copy link
Contributor Author

evhan commented Apr 29, 2019

Rebased and simplified slightly, still tests OK. Any thoughts on this?

@ahiaao
Copy link
Contributor

ahiaao commented Nov 19, 2019

Just tested this and it fixes the build for release-19.09 and master. I also noticed that while building the sql-de-lite egg it complained about how sqlite is missing. This can be fixed by adding the missing input to sql-de-lite in pkgs/tools/backup/ugarit/eggs.nix

@benley
Copy link
Member

benley commented Feb 19, 2020

Anyone know of a reason not to merge this?

@disassembler
Copy link
Member

@GrahamcOfBorg build ugarit

@disassembler disassembler merged commit c82021a into NixOS:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants