Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash: scrolling down list of (none) GS parameters #6453

Closed
DorpsGek opened this issue Apr 25, 2016 · 7 comments
Closed

Crash: scrolling down list of (none) GS parameters #6453

DorpsGek opened this issue Apr 25, 2016 · 7 comments
Labels
bug Something isn't working component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay stale Stale issues

Comments

@DorpsGek
Copy link
Member

Samu opened the ticket and wrote:

To reproduce this bug, I used GS Villages Is Villages v2 which contains many parameter items in its configuration, forcing a vertical scrollbar to be active.

Steps:

- launch OpenTTD
- click AI/Game Script Settings
- click GS slot, click Select Game Script and select Villages is Villages, click Accept.
- click Configure and let this window open.
- click Select Game Script and select (none), click Accept.

bug 1: Configure window didn't close.
bug 2: Vertical scrollbar is still reflecting the amount of parameter items of Villages Is Villages

- click on the scrollbar to scroll down...
... OpenTTD crashes.

Attachments

Reported version: 1.6.0
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/6453
@DorpsGek
Copy link
Member Author

Samu wrote:

Uploading another crash that can occur due to the Configure window not closing. This time it was a mix of two AIs and a dropdown list. It's difficult to trigger this crash. Sometimes when selecting a label from the dropdown crashes, sometimes it doesn't. Steps are quite similar.

Steps:

- launch OpenTTD
- click AI/Game Script Settings
- click an AI slot, click Select AI, select an AI which you know it contains a dropdown parameter
- click Configure, expand the dropdown list, and let this window open without chosing a value from the dropdown list
- click Select AI and select another AI, click Accept.

bug 1: Configure window didn't close.
bug 2: Dropdown list is still reflecting the values from the previous AI

- click on a value from the dropdown list...
... OpenTTD may or may not crash.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6453#comment14166

@DorpsGek
Copy link
Member Author

Samu wrote:

Mixed up parameters of Chopper and AdmiralAI when I last switched to Random AI.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6453#comment14167

@DorpsGek
Copy link
Member Author

Samu wrote:

Just found out that it can also crash for View readme, Changelog and License windows in a very similar fashion. They didn't close when Selecting another AI or GS and clicking Accept.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6453#comment14170

@DorpsGek
Copy link
Member Author

DorpsGek commented May 4, 2016

Samu wrote:

This is a crash report for NewGRF Settings window, which is similar in nature.

Steps:

- launch OpenTTD
- click NewGRF Settings
- have 1 active NewGRF file
- click License button
- without closing the License window, remove the active NewGRF file...

... OpenTTD crash.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6453#comment14175

@DorpsGek
Copy link
Member Author

3298 wrote:

Attaching a simple patch that prevents the issues that eventually lead to the crashes. It closes the parameters window and the textfile window more aggressively. The new behavior is also consistent with other settings windows: one or the other can be open - the parameters and textfile close when the list is opened.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6453#comment14635

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
@TrueBrain TrueBrain added patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay bug Something isn't working and removed bug from FlySpray labels Apr 10, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

I can't repro this behaviour at all. Assuming prior fix, maybe someone applied this patch or fixed it independently, I'm not going gravedigging to find out. Thanks!

@SamuXarick SamuXarick mentioned this issue Jan 23, 2019
Closed
@SamuXarick
Copy link
Contributor 

      I can't repro this behaviour at all.  Assuming prior fix, maybe someone applied this patch or fixed it independently, I'm not going gravedigging to find out.  Thanks!

it was fixed in svn r27787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay stale Stale issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TrueBrain @andythenorth @DorpsGek @SamuXarick