Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.black: fix build #53895

Merged
merged 1 commit into from Jan 15, 2019
Merged

pythonPackages.black: fix build #53895

merged 1 commit into from Jan 15, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 13, 2019

Motivation for this change
  • Add aiohttp to dependencies, because blackd requires it.
  • Fix darwin build.

Fixes #53890

cc: @abathur

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner January 13, 2019 20:26
@Mic92
Copy link
Member

Mic92 commented Jan 13, 2019

@GrahamcOfBorg build python37Packages.black python37Packages.pyls-black

@Mic92
Copy link
Member

Mic92 commented Jan 13, 2019

I get the same test failures on x86_64-linux.

@marsam
Copy link
Contributor Author

marsam commented Jan 14, 2019

that is weird, I can build it on x86_64-linux https://gist.github.com/2f62b7f51aa540ef0653f3cc966b5f90. The tests that fails in ofborg are related to cached results, the only thing that occurs me is to disable those tests

@marsam
pythonPackages.black: fix build
7412dc5 
* Add aiohttp to dependencies, because `blackd` requires it.
* Fix darwin build.
@marsam
Copy link
Contributor Author

marsam commented Jan 15, 2019

I still don't know why those tests fail, so I've opted for disable them

@Mic92 Mic92 merged commit e8c9962 into NixOS:master Jan 15, 2019
@marsam marsam deleted the fix-python-black branch January 15, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @Mic92 @GrahamcOfBorg