Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blender: fix python #53894

Merged
merged 1 commit into from Jan 14, 2019
Merged

blender: fix python #53894

merged 1 commit into from Jan 14, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jan 13, 2019

Motivation for this change

Error log is the same as the one in hydra, https://hydra.nixos.org/build/87274497/nixlog/1, if I remember correctly. Got no clue why it builds if I add m but it does. Extracted from diff in commit 570d84a.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
Copy link
Contributor

hedning commented Jan 13, 2019

@GrahamcOfBorg build blender

@vcunat
Copy link
Member

vcunat commented Jan 13, 2019 •
edited

@FRidh authored the 0a2caa4 change and surely understands python packaging better than me. This fixes the build for me.

@vcunat vcunat mentioned this pull request Jan 13, 2019
Closed
@vcunat vcunat added 6.topic: python 0.kind: regression Something that worked before working no longer labels Jan 13, 2019
@FRidh
Copy link
Member

FRidh commented Jan 14, 2019

The m indicates it should use pymalloc.
https://stackoverflow.com/questions/16675865/difference-between-python3-and-python3m-executables
I thought the m version was a link to the other one, apparently not.

@FRidh FRidh merged commit f97baf1 into NixOS:master Jan 14, 2019
@eadwu eadwu deleted the blender/python-fix branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eadwu @hedning @vcunat @FRidh @GrahamcOfBorg