Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-18.03: linux: Fix kernel build for Linux >= 4.14.90 #53892

Merged
merged 1 commit into from Jan 13, 2019
Merged

release-18.03: linux: Fix kernel build for Linux >= 4.14.90 #53892

merged 1 commit into from Jan 13, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jan 13, 2019

Fixes #53891.

Similar to commit 98ac571.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (still building)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 mentioned this pull request Jan 13, 2019
Closed
@samueldr samueldr merged commit 138f2cc into NixOS:release-18.03 Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nh2 @vcunat @samueldr @GrahamcOfBorg