Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enpass: 5.6.5 -> 6.0.1 #53849

Merged
merged 1 commit into from Feb 24, 2019
Merged

enpass: 5.6.5 -> 6.0.1 #53849

merged 1 commit into from Feb 24, 2019

Conversation

guillaumekoenig
Copy link
Contributor

Motivation for this change

Update enpass to new version 6, which is the version expected by the recent browser plugin update. They made significant changes, including the way it communicates with the browser (ie with the new helper "importer_enpass") which explains somes of the changes of this commit. I made sure to test the following before submitting for review : reusing setup from enpass 5, syncing from scratch a password db, using it to login via browser plugin (firefox and chrome).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thanegill
Copy link
Contributor

Been testing this for the last month. Any chance that this can get merged?

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build enpass

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

used nix-review to build on NixOS; clicking around in the application seemed to work fine.

@ryantm ryantm merged commit d97724e into NixOS:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guillaumekoenig @thanegill @ryantm @GrahamcOfBorg