Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpupower: fix w/linux 5, rework a bit #53902

Merged
merged 2 commits into from Jan 16, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 13, 2019

Motivation for this change

Primarily need to specify where to install bash completions,
or the build fails attempting to write to invalid location.

The rest is because I was going cross-eyed checking I didn't typo
one of the "dir" flags, but I can see this either way.

General trend seems to be away from "$(out)" usage here,
in favor of the placholder builtin for the
definitely-not-shell-escape-problem factor :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 16, 2019

@GrahamcOfBorg build linuxPackages_testing.cpupower

@Mic92 Mic92 merged commit bd3957d into NixOS:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants