Fix #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsmh
changed the title
|
Tested, solves the issues described in #6599, needs a review. |
LordAro
requested changes
Jan 13, 2019
Eddi-z
force-pushed
the
6599
branch
2 times, most recently
from
9f521b6
to
4aaed36
Compare
Eddi-z
commented
Jan 27, 2019
src/build_vehicle_gui.cpp
Outdated
| @@ -93,7 +94,7 @@ static const CargoID CF_NONE = CT_INVALID; ///< Show only vehicles which do not | |||
|
|
|||
| Listing _engine_sort_last_sorting[VEH_COMPANY_END] = { { 0, false }, { 0, false }, { 0, false }, { 0, false } }; | |||
| bool _engine_sort_show_hidden_engines[VEH_COMPANY_END] = {false, false, false, false}; ///< Last set 'show hidden engines' setting for each vehicle type. | |||
| static CargoID _engine_sort_last_cargo_criteria[VEH_COMPANY_END] = {CF_ANY, CF_ANY, CF_ANY, CF_ANY}; ///< Last set filter criteria, for each vehicle type. | |||
| static byte _engine_sort_last_cargo_criteria[VEH_COMPANY_END] = {CF_ANY, CF_ANY, CF_ANY, CF_ANY}; ///< Last set filter criteria, for each vehicle type. | |||
|
|
|||
There was a problem hiding this comment.
I'm not entirely sure what this change is doing here
nielsmh
requested changes
Jan 28, 2019
|
In #6599, this is a problem:
The sortlist changes might be okay but they're nothing to do with disabling the Buy button. |
|
Already fixed by #7217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches imported as PR
not implemented or tested by me
minor conflict resolved
Fixes #6599