vscode-extensions.ms-python.python: Fix packaging. #53923
Conversation
Previously, this extension used the JEDI backend for understanding Python. Recently, Microsoft switched to using their Python Language Server (https://github.com/Microsoft/python-language-server). The extension attempts to download the latest version into the extension folder, which failed for obvious reasons. This change packages the language server into the extension, and performs the necessary fixups and wrapping to make the dotnet binary run. Tested on Linux x86_64, but it should work on Darwin too.
| }; | ||
| meta = with lib; { | ||
| license = licenses.mit; | ||
| maintainers = [ maintainers.jraygauthier maintainers.sdorminey ]; |
There was a problem hiding this comment.
I think you only have to do this if you want to become a maintainer of a package. Up to you.
https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes
| ''; | ||
| }; | ||
|
|
||
| languageServer = extractNuGet rec { |
There was a problem hiding this comment.
Are other packages going to want to use this language server? Should it be packaged separately?
GrahamcOfBorg
added
10.rebuild-darwin: 0
| buildInputs = [ languageServer icu openssl ]; | ||
| dontPatchELF = true; | ||
|
|
||
| buildPhase = '' |
There was a problem hiding this comment.
I would prefer if this phase happened in the python language server derivation.
Also I think it makes more sense for the installation here to be in the installPhase and the patching and wrapping to happen at postFixup.
| ''; | ||
|
|
||
| fixupPhase = '' | ||
| wrapProgram `find $out -name Microsoft.Python.LanguageServer` --prefix LD_LIBRARY_PATH ":" ${icu}/lib:${openssl.out}/lib |
There was a problem hiding this comment.
Any reason why having this in rpath isn't done?
|
Haven't had any response in while, so I'm afraid it would customary for me to close this. Thanks 🌟 |
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
Previously, this extension used the JEDI backend for understanding
Python. Recently, Microsoft switched to using their Python Language
Server (https://github.com/Microsoft/python-language-server). The
extension attempts to download the latest version into the extension
folder, which failed for obvious reasons.
This change packages the language server into the extension, and
performs the necessary fixups and wrapping to make the dotnet binary
run.
Tested on Linux x86_64, but it should work on Darwin too.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Before: 2794344 After: 2869216