Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vivaldi: 2.1.1337.51-1 -> 2.2.1388.37-1; vivaldi-ffmpeg-codecs: 70.0.3538.77 -> 71.0.3578.98 #53315

Merged
merged 2 commits into from Jan 3, 2019
Merged

vivaldi: 2.1.1337.51-1 -> 2.2.1388.37-1; vivaldi-ffmpeg-codecs: 70.0.3538.77 -> 71.0.3578.98 #53315

merged 2 commits into from Jan 3, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 3, 2019

Motivation for this change

Update vivaldi.

  • vivaldi: 2.1.1337.51-1 -> 2.2.1388.37-1
  • vivaldi-ffmpeg-codecs: 70.0.3538.77 -> 71.0.3578.98

Minor update for Vivaldi 2.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@romildo Mind preparing a backport pr after this is merged?
Figured that this was something we should do in #51711.

@worldofpeace worldofpeace merged commit 3e00845 into NixOS:master Jan 3, 2019
@romildo
Copy link
Contributor Author

romildo commented Jan 3, 2019

@romildo Mind preparing a backport pr after this is merged?

@worldofpeace It should be easy, but I have not done a backport before. Would someone tell me how it is done?

@romildo romildo deleted the upd.vivaldi branch January 3, 2019 20:08
@worldofpeace
Copy link
Contributor

Should just be https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches.
Just those exact commits from master to release-18.09.

@romildo romildo mentioned this pull request Jan 3, 2019
Merged
10 tasks
@romildo
Copy link
Contributor Author

romildo commented Jan 3, 2019

@worldofpeace I hope I have done it right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @worldofpeace @GrahamcOfBorg