Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofimoji: init at 2017-10-31 #53297

Closed
wants to merge 1 commit into from
Closed

rofimoji: init at 2017-10-31 #53297

wants to merge 1 commit into from

Conversation

wedens
Copy link

@wedens wedens commented Jan 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wedens wedens closed this Jan 26, 2019
@siers
Copy link
Member

siers commented Jan 20, 2020

Why close this instead of pinging "the higherups"? 😀

@siers
Copy link
Member

siers commented Jan 20, 2020

Ah, it's out of date.

@siers
Copy link
Member

siers commented Jan 20, 2020

You'd forgotten to include rofi as a dependency! Ha! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wedens @siers @GrahamcOfBorg