Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/cpufreq: Remove the alias to set the cpu frequency governor #53301

Merged
merged 1 commit into from Jan 3, 2019
Merged

nixos/cpufreq: Remove the alias to set the cpu frequency governor #53301

merged 1 commit into from Jan 3, 2019

Conversation

cdepillabout
Copy link
Member

This PR temporarily fixes the issue with PR 53041 as explained here:

#53041 (comment)

The alias powerManagement.cpufreq.governor to powerManagement.cpuFreqGovernor has been removed.

Motivation for this change

This fixes a bad interaction between the TLP module and powerManagement.cpuFreqGovernor which has been set in nixos-generate-config.

Pinging @infinisil because of his suggestion to revert this change, as well as @eadwu since he originally reported the error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
nixos/cpufreq: Remove the alias to set the cpu frequency governor
46ecec8 
This PR temporarily fixes the issue with PR 53041 as explained
here:

NixOS#53041 (comment)

The alias `powerManagement.cpufreq.governor` to
`powerManagement.cpuFreqGovernor` has been removed.
@infinisil infinisil merged commit 2b1c9fd into NixOS:master Jan 3, 2019
@cdepillabout cdepillabout deleted the remove-cpufreqgov-alias branch January 4, 2019 00:38
@cdepillabout cdepillabout mentioned this pull request Jan 6, 2019
Merged
10 tasks
@luochen1990
Copy link
Contributor

Why there is still a TODO says This should be aliased to powerManagement.cpufreq.governor. in the code if the alias is not a good idea? Maybe we should delete the TODO?

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/tasks/cpu-freq.nix#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cdepillabout @luochen1990 @infinisil @GrahamcOfBorg