Add: downloads pages, and links from header/index to them #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise {{ base }} is not always set. This is safer.
TrueBrain
commented
Jan 2, 2019
TrueBrain
force-pushed
the
downloads
branch
2 times, most recently
from
cdac67b
to
34715cd
Compare
LordAro
requested changes
Jan 4, 2019
When the docker is build, information is downloaded (via HTTP) from finger.openttd.org and binaries.openttd.org to figure out what the available downloads are, and those are added to the collection. Jekyll after that makes this into static files. Yes, this does mean we have to rebuild this container every time we make a new release. But those events are rare.
LordAro
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.