Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh.syntaxHighlighting: add option to customize styles #53245

Merged
merged 1 commit into from Jan 29, 2019
Merged

zsh.syntaxHighlighting: add option to customize styles #53245

merged 1 commit into from Jan 29, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jan 2, 2019 •
edited

Motivation for this change

Add option to customize styles in plugin syntaxHighlighting

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Jan 16, 2019

cc @Mic92 @infinisil

makefu
makefu approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality with nixos-shell and config, sane defaults and examples

{ pkgs, ...}: {
  programs.zsh = {
    enable = true;
    syntaxHighlighting = {
      enable = true;
      styles = {
        alias = "fg=magenta,bold";
      };
    };
  };
  users.users.test = {
    initialPassword = "lol";
    isNormalUser = true;
    shell = "/run/current-system/sw/bin/zsh";
  };
}

@grahamc grahamc merged commit 0fe1645 into NixOS:master Jan 29, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Jan 29, 2019

Thanks!

@Izorkin Izorkin deleted the zsh-syntaxHighlighting branch January 29, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu makefu approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @makefu @grahamc @GrahamcOfBorg