Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 6.15.1 -> 6.16.0, 8.14.1 -> 8.15.0, 10.12.0 -> 10.15.0, 11.5.0 -> 11.6.0 #53270

Merged
merged 4 commits into from Jan 4, 2019
Merged

nodejs: 6.15.1 -> 6.16.0, 8.14.1 -> 8.15.0, 10.12.0 -> 10.15.0, 11.5.0 -> 11.6.0 #53270

merged 4 commits into from Jan 4, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 3, 2019 •
edited

Motivation for this change

Node 6.16.0: https://nodejs.org/en/blog/release/v6.16.0/
Node 8.15.0: https://nodejs.org/en/blog/release/v8.15.0/
Node 10.15.0: https://nodejs.org/en/blog/release/v10.15.0/
Node 11.6.0: https://nodejs.org/en/blog/release/v11.6.0/

because some breaking changes in the previous releases, these commits need to be backported to 18.09

Pointing to staging because requires 5b9ad12e7be

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam changed the base branch from master to staging January 3, 2019 23:15
@adisbladis
Copy link
Member

@GrahamcOfBorg build nodejs-6_x nodejs-8_x nodejs-10_x nodejs-11_x

@adisbladis adisbladis merged commit f5be652 into NixOS:staging Jan 4, 2019
@marsam marsam deleted the update-nodejs branch January 4, 2019 02:42
This was referenced Jan 4, 2019
Merged
Closed
Closed
adisbladis added a commit that referenced this pull request Feb 12, 2019
@adisbladis
Merge pull request #53375 from adisbladis/nodejs-backports
0a3561a 
Backport nodejs from #53270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @adisbladis @GrahamcOfBorg