Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/display-managers: allow pure wayland sessions #53288

Merged
merged 1 commit into from Jan 3, 2019
Merged

nixos/display-managers: allow pure wayland sessions #53288

merged 1 commit into from Jan 3, 2019

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Jan 3, 2019 •
edited

Fixes #53277 (hopefully).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@suhr suhr requested a review from infinisil as a code owner January 3, 2019 09:27
@jtojnar jtojnar requested a review from hedning January 3, 2019 10:35
@jtojnar jtojnar merged commit 24d1d6c into NixOS:master Jan 3, 2019
@suhr suhr deleted the pure_wayland branch February 23, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suhr @hedning @jtojnar @GrahamcOfBorg