Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable memory hotplug support #54095

Merged
merged 1 commit into from Jan 19, 2019
Merged

Enable memory hotplug support #54095

merged 1 commit into from Jan 19, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 16, 2019 •
edited

Motivation for this change

Enable users to hotplug memory in NixOS. Resolves #53814.

Used https://www.mjmwired.net/kernel/Documentation/memory-hotplug.txt as a reference.
Notes on testing: http://www.supermaru.com/2016/10/hot-add-cpu-memory-ubuntu-guest-vmware/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested dynamically adding RAM inside a VMWare guest on NixOS
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/hot-adding-memory/1857/5

@teto
Copy link
Member

teto commented Jan 17, 2019

The kernel config is already too big IMHO so not too fond of enabling even more features.
Maybe we need to have different configs for the kernel (normal/full) to have the cache working for everyone. Otherwise with this #42838, enabling VMware could update the kernel config.

@aanderse
Copy link
Member Author

@teto This is an absolute basic requirement for enterprise, which at least several NixOS developers have said they want to better support.

Different kernel configs sounds like a great idea too, but is that something that could be ready for 19.03?

@hedning
Copy link
Contributor

hedning commented Jan 18, 2019

This should probably target staging.

@vcunat
Copy link
Member

vcunat commented Jan 18, 2019

We usually send kernel-only changes directly to master.

@samueldr
Copy link
Member

Queuing builds one at a time to spread the timeout window...

@GrahamcOfBorg build linuxPackages_4_4.kernel

@samueldr
Copy link
Member

@GrahamcOfBorg build linuxPackages_4_14.kernel

@vcunat vcunat merged commit e634140 into NixOS:master Jan 19, 2019
vcunat added a commit that referenced this pull request Jan 19, 2019
@vcunat
Merge #54095: linux: enable memory hotplug support
23eb5e8
@aanderse
Copy link
Member Author

Thanks!

@aanderse aanderse deleted the memory-hotplug branch January 19, 2019 15:34
vcunat added a commit that referenced this pull request Jan 19, 2019
@vcunat
linux: avoid memory hotplug support on most platforms
3fa7729 
It broke i686 build, and it's probably not worth it on others, too.
/cc #54095 e634140.
@hedning
Copy link
Contributor

hedning commented Jan 19, 2019

Looks like this broke the kernel on i686 unfortunately: https://hydra.nixos.org/build/87601303

error: unused option: ACPI_HOTPLUG_MEMORY

@vcunat
Copy link
Member

vcunat commented Jan 20, 2019

Yes, I had pushed the commit mentioned above: 3fa7729.

@hedning
Copy link
Contributor

hedning commented Jan 20, 2019

Ah, duh, nevermind me.

@aanderse aanderse mentioned this pull request Jul 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

@samueldr samueldr samueldr approved these changes

Assignees
No one assigned
Labels
6.topic: kernel 10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@aanderse @nixos-discourse @teto @hedning @vcunat @samueldr @zimbatm @GrahamcOfBorg