Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iwd: 0.12 -> 0.14 #54125

Merged
merged 2 commits into from Feb 10, 2019
Merged

iwd: 0.12 -> 0.14 #54125

merged 2 commits into from Feb 10, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 16, 2019

https://git.kernel.org/pub/scm/network/wireless/iwd.git/diff/ChangeLog?h=0.13
https://git.kernel.org/pub/scm/network/wireless/iwd.git/diff/ChangeLog?h=0.14

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 17, 2019

Still hoping they allow me to match certificates on sub domains so I can use it in eduroam: https://git.kernel.org/pub/scm/network/wireless/iwd.git/tree/TODO?h=0.14#n329

@dtzWill
Copy link
Member Author

dtzWill commented Jan 17, 2019

LGTM, using it now with #51803, FWIW 😁.

eduroam would be nice, will keep an eye on that as well!

jokogr
jokogr approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@jokogr jokogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using it with (a slightly patched) connman on a machine, it has been working flawlessly.

@Mic92 Mic92 merged commit 4ec7a52 into NixOS:master Feb 10, 2019
@Mic92
Copy link
Member

Mic92 commented Feb 10, 2019

Ah yeah, this also likely broken conman before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@jokogr jokogr jokogr approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @Mic92 @jokogr @worldofpeace @GrahamcOfBorg