Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postman: 6.3.0 -> 6.7.1 #54101

Merged
merged 2 commits into from Jan 17, 2019
Merged

postman: 6.3.0 -> 6.7.1 #54101

merged 2 commits into from Jan 17, 2019

Conversation

ngerstle-cognite
Copy link
Contributor

@ngerstle-cognite ngerstle-cognite commented Jan 16, 2019 •
edited

postman: 6.3.0 -> 6.7.1

Motivation for this change

A simple update from 6.3.0 to 6.7.1 fixes a breaking bug - something about requested version 30 being less than version 80 during startup?
Either way, 6.7.1 seems to solve the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ngerstle-cognite
Update postman to 6.7.1
8f50660 
A simple update from 6.3.0 to 6.7.1 fixes a breaking bug - something about requested version 30 being less than version 80 during startup?
Either way, 6.7.1 seems to solve the issue.
@nyanloutre
Copy link
Member

Thanks for the contribution !

You just should rewrite your commit message by following the standard scheme: https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

@Mic92 Mic92 changed the title Update postman to 6.7.1 postman: 6.3.0 -> 6.7.1 Jan 17, 2019
Mic92
Mic92 reviewed Jan 17, 2019
View reviewed changes
pkgs/development/web/postman/default.nix Outdated

src = fetchurl {
url = "https://dl.pstmn.io/download/version/${version}/linux64";
sha256 = "09m511y977478567lc28mhy68b99ssajzhirc1c4anxnvvs7s6fa";
sha256 = "091k51km4lfxlksm8imkr30yli0zzbbajqp0fdk7r6migzm5k960";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a different checksum here:

hash mismatch in fixed-output derivation '/nix/store/b5lzk1wa0087msx6316wsflfpihr2p24-postman-6.7.1.tar.gz':
  wanted: sha256:091k51km4lfxlksm8imkr30yli0zzbbajqp0fdk7r6migzm5k960
  got:    sha256:1x8jj0xs67wi0qj6x22h54crndml6fl8a128s57v058fyxji6brx
cannot build derivation '/nix/store/rawmx5sbnnam3dr0542c7vbfj0hqz7qr-postman-6.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mi4r8llng56aw0ma4qqhz4pvnb755rsx-env.drv': 1 dependencies couldn't be built

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I am as well, I wonder why it worked last night with the different sha sum...
will fix.

@ngerstle-cognite
Update default.nix
a282a5d 
fix sha sum
@Mic92 Mic92 merged commit c7c6c35 into NixOS:master Jan 17, 2019
@ngerstle-cognite ngerstle-cognite deleted the patch-1 branch January 17, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ngerstle-cognite @nyanloutre @Mic92 @GrahamcOfBorg @Janik-Haag