Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/ofborg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 22e7d0ae8db8
Choose a base ref
...
head repository: NixOS/ofborg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e7e6d7314ab9
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jan 16, 2019

  1. request reviews one at a time 

    if a batch of review requests contains any users who are not members of the organization, the entire request fails.
    @grahamc
    grahamc committed Jan 16, 2019
    Copy the full SHA
    f151c71 View commit details

  2. Merge pull request #303 from NixOS/request-reviews-one-at-a-time 

    request reviews one at a time
    @grahamc
    grahamc authored Jan 16, 2019
    Copy the full SHA
    e7e6d73 View commit details
Showing with 10 additions and 12 deletions.
  1. +10 −12 ofborg/src/tasks/massrebuilder.rs
22 changes: 10 additions & 12 deletions ofborg/src/tasks/massrebuilder.rs
View file
Original file line number Diff line number Diff line change
@@ -737,18 +737,16 @@ fn request_reviews(
) {
if let Ok(ref maint) = m {
if maint.maintainers().len() < 10 {
if let Err(e) =
pull.review_requests()
.create(&hubcaps::review_requests::ReviewRequestOptions {
reviewers: maint.maintainers(),
team_reviewers: vec![],
})
{
println!(
"Failure adding review requests for maintainers ({:?}): {:#?}",
maint.maintainers(),
e,
);
for maintainer in maint.maintainers() {
if let Err(e) =
pull.review_requests()
.create(&hubcaps::review_requests::ReviewRequestOptions {
reviewers: vec![maintainer.clone()],
team_reviewers: vec![],
})
{
println!("Failure requesting a review from {}: {:#?}", maintainer, e,);
}
}
}
}