Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatpak: 1.1.2 -> 1.1.3 #54061

Merged
merged 2 commits into from Jan 16, 2019
Merged

flatpak: 1.1.2 -> 1.1.3 #54061

merged 2 commits into from Jan 16, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 16, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 16, 2019

https://github.com/flatpak/flatpak/releases/tag/1.1.3

Apparently appstream-glib is still needed by something:

https://github.com/flatpak/flatpak/blob/1.1.3/configure.ac#L273

@dtzWill dtzWill merged commit 11c0c03 into NixOS:master Jan 16, 2019
@dtzWill dtzWill deleted the update/flatpak-1.1.3 branch January 16, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @jtojnar @GrahamcOfBorg