Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See linked issue for discussion,
but key bits:
My "day-job" project broke with LLVM 7
until I found my way to this, d'oh!
I don't think we need to worry about
ABI the same way the folks on the issue do.
(and aligning with GCC ABI is much more important
than ABI-compat with previous LLVM major)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)BTW debugging this is kinda neat in a painful way,
as the value --without any writes or instructions--
appears to corrupt itself when passed as an argument.
(it doesn't change but your debugger might say it does!)