Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm7: patch to fix PR39427 #54122

Merged
merged 1 commit into from Jan 17, 2019
Merged

llvm7: patch to fix PR39427 #54122

merged 1 commit into from Jan 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 16, 2019

Motivation for this change

See linked issue for discussion,
but key bits:

  • rustc breaks without this
  • fix changes ABI, may become 7.1.0

My "day-job" project broke with LLVM 7
until I found my way to this, d'oh!

I don't think we need to worry about
ABI the same way the folks on the issue do.

(and aligning with GCC ABI is much more important
than ABI-compat with previous LLVM major)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

BTW debugging this is kinda neat in a painful way,
as the value --without any writes or instructions--
appears to corrupt itself when passed as an argument.
(it doesn't change but your debugger might say it does!)

See linked issue for discussion,
but key bits:

* rustc breaks without this
* fix changes ABI, may become 7.1.0
@Mic92 Mic92 merged commit 6d3ed73 into NixOS:staging Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants