Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools.example.runAsRootParentImage: init #52959

Merged
merged 1 commit into from Dec 29, 2018
Merged

dockerTools.example.runAsRootParentImage: init #52959

merged 1 commit into from Dec 29, 2018

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Dec 27, 2018

Example of running something as root on top of a parent image.
This is a regression test related to the PR #52109.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nlewo
dockerTools.examples.runAsRootParentImage: init
43cbba0 
Example of running something as root on top of a parent image.
This is a regression test related to the PR NixOS#52109.
@nlewo nlewo merged commit bb86d0c into NixOS:master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puffnfresh puffnfresh puffnfresh approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlewo @puffnfresh @GrahamcOfBorg