-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSTU booster tooling, reimport nose/mount model lengths #958
Conversation
@manufacturer = SSTU | ||
@description = Level II-equivalent booster fuel tank. Used on the R-7 and similar to tanks on the Redstone, R-5, and Able rockets. Can be configured with normal or high pressurization. High pressurization tanks are required by some engines and they are heavier than normal tanks. <b><color=green>Max Utilization: 92% | ||
|
||
@maxTemp = 773.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you configuring the physical properties via RP-1? These all must be part of RO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question/catch, i guess we were just copying the parts from above. I assume pap also only copy/pasted it, so i'll remove all the physical properties in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what i see, everything except the ModuleToolingSSTUTank module should be moved over to RO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's another good question. For RP-0, NK created 4 "levels" of fuel tanks, level 1-4, to have a tech progression. Without any progression, you technically don't need those 4 tank levels in RO, but i can see your point, they're physical things and you still might want to recreate an early rocket with procedural parts just using RO. We should probably get some more opinions on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a similar situation with the "X-Ray" probe core. It was an RP-0-only part and it was impossible to actually test a craft file that included it under just RO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so we change the physical properties of the descendant tanks, so the values itself belong to the part. Well, but actually always to the exact same value, so it really should move to RO.
About the move, the plan seems to be to go ahead with this PR, and move the parts over to RO later, together with procedural avionics i assume.
…o match their real VAB lengths
1632565
to
fa2bb2f
Compare
No description provided.