Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-sso: init at 0.15.1 (+ nixos service/test) #53002

Merged
merged 3 commits into from Jan 29, 2019
Merged

nginx-sso: init at 0.15.1 (+ nixos service/test) #53002

merged 3 commits into from Jan 29, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Dec 28, 2018

Motivation for this change

nginx-sso is a simple, self-contained backend for nginx's auth_request module. It can be used to implement login/logout across a set of services on a web domain, and supports 2FA (TOTP) as well as multiple authentication backends.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth delroth changed the title nginx-sso: init at 0.12.0 (+ nixos service/test) nginx-sso: init at 0.14.0 (+ nixos service/test) Dec 29, 2018
@delroth delroth changed the title nginx-sso: init at 0.14.0 (+ nixos service/test) nginx-sso: init at 0.15.1 (+ nixos service/test) Jan 24, 2019
@delroth
Copy link
Contributor Author

delroth commented Jan 24, 2019

Ping? :-)

infinisil
infinisil requested changes Jan 26, 2019
View reviewed changes
nixos/modules/services/security/nginx-sso.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/nginx-sso.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/nginx-sso.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/nginx-sso.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/nginx-sso.nix Show resolved Hide resolved
@delroth delroth force-pushed the nginx-sso branch 2 times, most recently from 87b31b5 to b708c1c Compare January 29, 2019 02:40
@delroth
Copy link
Contributor Author

delroth commented Jan 29, 2019

@infinisil addressed your comments fyi (not sure if you get notifications from the "resolve" button).

@infinisil infinisil merged commit 400912d into NixOS:master Jan 29, 2019
@infinisil
Copy link
Member

Ah, I missed it now, but for the future, commits that add a new nixos service usually should look like "nixos/foo: init"

@delroth
Copy link
Contributor Author

delroth commented Jan 29, 2019

Noted. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @infinisil @GrahamcOfBorg