Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dlang update 2018-12 #52964

Merged
merged 5 commits into from Jan 1, 2019
Merged

Dlang update 2018-12 #52964

merged 5 commits into from Jan 1, 2019

Conversation

ThomasMader
Copy link
Contributor

Motivation for this change

Updating dlang related packages to newer versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ThomasMader
Copy link
Contributor Author

@GrahamcOfBorg build ldc dmd dtools dub Literate

@ThomasMader
Copy link
Contributor Author

#51720 is now obsolete because of this PR.

@ThomasMader
Copy link
Contributor Author

ThomasMader commented Dec 27, 2018 •
edited

This is ready to be merged.
The test build on linux failed but the build machine probably has an old nix version. It seems to be this problem: NixOS/nix#2155

@xeji
Copy link
Contributor

xeji commented Jan 1, 2019

ofborg build timed out, let's try again
@GrahamcOfBorg build ldc dmd dtools dub Literate

@xeji
Copy link
Contributor

xeji commented Jan 1, 2019

builds still timed out on ofborg but succeeded locally

@xeji xeji merged commit 6056319 into NixOS:master Jan 1, 2019
@xeji xeji mentioned this pull request Jan 1, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThomasMader @xeji @GrahamcOfBorg