Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lenovo x1 carbon gen6: update S3 suspend #88

Merged
merged 1 commit into from Dec 28, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Dec 27, 2018

With UEFI >= 1.30, there's an explicit option to enable S3 power management.
Once this is selected, S3 is enabled and "deep" is selected as the default
/sys/power/mem_sleep value without requiring any kernel boot parameters.

@bhipple
Copy link
Contributor Author

bhipple commented Dec 27, 2018

CC @azazel75 @FruitieX I see from https://discourse.nixos.org/t/nixos-on-x1-carbon/1627 that you're using this laptop; if you haven't done so already, you may want to upgrade your UEFI version to the latest one that supports the efficient sleep by default.

@azazel75
Copy link
Contributor

@bhipple , well done! I've actually updated several days ago but hadn't found the time yet to submit a patch. +1 for me

@azazel75
Copy link
Contributor

Just one note, are you sure that it isn't better to reference the firmware upgrade as "BIOS version >= 1.30" instead of "UEFI"? The archlinux wiki too refers to it as "BIOS update" https://wiki.archlinux.org/index.php/Lenovo_ThinkPad_X1_Carbon_(Gen_6)#Enabling_S3 and you can actually check your version entering the BIOS configuration utility

@@ -2,7 +2,9 @@
# standing with kernel 4.6.11 is the following wiki page:
# https://wiki.archlinux.org/index.php/Lenovo_ThinkPad_X1_Carbon_(Gen_6). The
# TrackPoint and TouchPad issues there seem to have been fixed already.

#
# Enable the lower-power S3 suspend state by upgrading UEFI to version >= 1.30,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to use BIOS instead of UEFI here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good point; upgraded comment accordingly.

With UEFI >= 1.30, there's an explicit option to enable S3 power management.
Once this is selected, S3 is enabled and "deep" is selected as the default
/sys/power/mem_sleep value without requiring any kernel boot parameters.
@lukateras lukateras merged commit a9033dc into NixOS:master Dec 28, 2018
@bhipple bhipple deleted the update/x1-carbon branch December 29, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants