Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

material-design-icons: init at 3.2.89 #52969

Merged
merged 1 commit into from Dec 30, 2018
Merged

material-design-icons: init at 3.2.89 #52969

merged 1 commit into from Dec 30, 2018

Conversation

vlaci
Copy link
Contributor

@vlaci vlaci commented Dec 27, 2018 •
edited

Motivation for this change

Package contains thousands of icons to be used in e.g. status bars in minimalist window managers.

It is a bit unfortunate that the name is so close to material-icons, however it is consistent with the project name and how it is present in AUR (ttf-material-design-icons-git)

Open questions
  • Should be the webfont stuff installed? I have seen few package doing it (comic-neue, unscii) so I have included them as well. However location off woff and svg files is not consistent across packages. I am happy to leave them out.
    - They are installed in current revision of the commit
  • Somewhat legal issue: Is it OK that upstream incorporated Google's material-icons (Apache-2.0) and redistributed them under OFL? I know Apache is not copyleft and OFL seams to offer the same guaranties as Apache. AFAIK it should be OK but I did not want this to go unnoticed.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Happy Holidays everyone!

@timokau
Copy link
Member

timokau commented Dec 29, 2018

Nice to see a new face/username! :)

What is the usecase for this? Why would someone need to install material design icons?

@vlaci
Copy link
Contributor Author

vlaci commented Dec 29, 2018

I have few more packages in my private repo that I'd like to integrate in the future :)
As I have mentioned in the PR I think it is mainly useful for widgets and other components in minimalistic WM panels and alike. I am using them in my AwesomeWM configuration:
image

timokau
timokau requested changes Dec 29, 2018
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then. A few nitpicks.

pkgs/data/fonts/material-design-icons/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/material-design-icons/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/material-design-icons/default.nix Outdated Show resolved Hide resolved
@timokau
Copy link
Member

timokau commented Dec 29, 2018

Should be the webfont stuff installed?

Doesn't really matter I guess. Shouldn't take much space.

Is it OK that upstream incorporated Google's material-icons (Apache-2.0) and redistributed them under OFL

I guess if its not okay upstream should be responsible for the licensing error, not us. Not sure about that though.

@vlaci vlaci force-pushed the pkg/mdi branch 2 times, most recently from e735c6e to 3ee5d25 Compare December 29, 2018 22:00
material-design-icons: init at 3.2.89
f031085 
It is a bit unfortunate that the name is so close to material-icons,
however it is consistent with the project name and how it is present
in AUR (ttf-material-design-icons-git)
@timokau
Copy link
Member

timokau commented Dec 30, 2018

@GrahamcOfBorg build material-design-icons

@timokau
Copy link
Member

timokau commented Dec 30, 2018

Looks good to me!

@timokau timokau merged commit bd12f74 into NixOS:master Dec 30, 2018
@vlaci vlaci deleted the pkg/mdi branch March 10, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vlaci @timokau @GrahamcOfBorg