Do not suppress rollback exceptions #1067
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the original motivation for this try/except block
was, though it seems to have been added several years ago. I think if
an exception occurs during rollback, it needs to be either handled
(though I'm not sure there's anything we could do with it) or surfaced
to the user; silent failures can only cause problems.
(I don't mind how the failure is presented; if you'd prefer to avoid a
top-level exception here I can re-add the try/except block with an
error message.)