firmware: fix MMCM multiplier & divisor calculation #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also warn if the calculated VCO frequency strays outside the datasheet specified range Signed-off-by: Rohit Singh <rohit91.2008@gmail.com>
rohitk-singh
force-pushed
the
mmcm_fix
branch
from
821096c
to
8208a45
Compare
|
@mithro @enjoy-digital Admittedly, we need better multiplier and divisor calculation. In the meantime, I've just added a warning in case VCO is configured with frequency outside the range. |
enjoy-digital
approved these changes
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the resulting pixel clock was 1/10th of the actual value. This PR fixes the calculation. Also added a warning in case the VCO frequency goes outside the allowed range.
The HDMI output is now working in Mimas A7 with this fix.