Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python27: add patch for CVE-2018-14647 #52996

Closed
wants to merge 1 commit into from
Closed

python27: add patch for CVE-2018-14647 #52996

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 28, 2018

Motivation for this change

Closes #52977

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner December 28, 2018 01:46
@marsam marsam changed the base branch from master to staging December 28, 2018 02:05
@FRidh
Copy link
Member

FRidh commented Dec 28, 2018

We need to add (version of) this patch to all interpreter versions.

@FRidh FRidh added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 28, 2018
FRidh
FRidh reviewed Dec 28, 2018
View reviewed changes
pkgs/development/interpreters/python/cpython/2.7/default.nix
@@ -80,6 +80,11 @@ let
url = "https://github.com/python/cpython/pull/8985.patch";
sha256 = "1c8nq2c9sjqa8ipl62hiandg6a7lzrwwfhi3ky6jd3pxgyalrh97";
})
# CVE-2018-14647. See https://bugs.python.org/issue34623
(fetchpatch {
url = "https://github.com/python/cpython/commit/18b20bad75b4ff0486940fba4ec680e96e70f3a2.patch";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/python/cpython/commit/10be1d3f802b874914b2a13eb41407c7a582d9b3.patch is the patch that's merged in the 2.7 branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That commit only adds the news entry. I've used the commit which includes the fix, it's also referenced in the Debian tracker https://security-tracker.debian.org/tracker/CVE-2018-14647

@FRidh
Copy link
Member

FRidh commented Dec 28, 2018

Also, you can target staging-next.

@marsam marsam changed the base branch from staging to staging-next December 28, 2018 11:28
@marsam
Copy link
Contributor Author

marsam commented Dec 28, 2018 •
edited

We need to add (version of) this patch to all interpreter versions.

python2.7 is the only affected.

@worldofpeace
Copy link
Contributor

ping @FRidh

@dotlambda
Copy link
Member

ping

@vcunat
Copy link
Member

vcunat commented Feb 17, 2019 •
edited

Leaving this unresolved is probably a bad PR, though we do have the newest expat on both master and 18.09 (and build python --with-system-expat), so we probably aren't affected.

It's not a security issue with recent versions of libexpat. The library initializes the salt from a good entry source by default.

@vcunat vcunat mentioned this pull request Feb 17, 2019
Closed
1 task
@marsam marsam closed this Feb 18, 2019
@marsam marsam deleted the python27-cve-2018-14647 branch February 18, 2019 15:41
@vcunat vcunat mentioned this pull request Mar 10, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marsam @FRidh @worldofpeace @dotlambda @vcunat @GrahamcOfBorg