Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm7: 7.0.0 -> 7.0.1 #52966

Closed
wants to merge 1 commit into from
Closed

llvm7: 7.0.0 -> 7.0.1 #52966

wants to merge 1 commit into from

Conversation

amirshavit
Copy link
Contributor

Motivation for this change

Bug-fix release: http://lists.llvm.org/pipermail/llvm-announce/2018-December/000081.html
Darwin build is broken as before (#46888)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Dec 29, 2018

Duplicate (but with some good info) of #52584 .

@dtzWill
Copy link
Member

dtzWill commented Dec 29, 2018

Looks like same changes as well, at a glance anyway. LMK if anything from this was missed, thanks for submitting!

@dtzWill dtzWill closed this Dec 29, 2018
@amirshavit amirshavit deleted the llvm_7.0.1 branch December 30, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amirshavit @dtzWill @GrahamcOfBorg @Janik-Haag