Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVTOOLS: semi-auto creation of SUBTITLES.MIX for Blade Runner #1468

Merged
merged 27 commits into from Jan 6, 2019

Conversation

antoniou79
Copy link
Contributor

@antoniou79 antoniou79 commented Dec 27, 2018

add make rules for output FON and MIX files

Create wrappers for all scripts to check for python 2.7
update module.mk to create FON file, then create the SUBTITLES.MIX file
Remove the intermediate TRE files.
Input is expected to be in sampleInput folder

  • subtitlesFont.png: The font glyphs input image file. Needed for the font creation (SUBTLS_E.FON)
  • overrideEncodingSUBLTS.txt: A configuration file for the font creation. A sample is provided in the sampleInput folder and documentation in the readme. Needed for the font creation (SUBTLS_E.FON)
  • englishTranscript.xls: The excel file with the transcript. This is the file maintained online. Needed for the SUBTITLES.MIX.
  • configureFontsTranslation.txt. A configuration file for the MIX creation. A sample is provided in the sampleInput folder and documentation in the readme. Needed for the SUBTITLES.MIX.

add make rules for output FON and MIX files

Create wrappers for all scripts to check for python 2.7
update module.mk to create FON file, then create the SUBTITLES.MIX file
Remove the intermediate TRE files.
Input is expected to be in sampleInput folder
@antoniou79
Copy link
Contributor Author

antoniou79 commented Dec 27, 2018

Should work with the make command:

make devtools/create_bladerunner/subtitles
  • The scripts require Python 2.7; they won't run with Python 3.0 and a (friendly) error message will be displayed about that.
  • The scripts are also now checking for missing required library modules (per script).

I intend to update the scripts to provide support for the localized versions of the game

Also added missing (renamed) script for MIX packer
Updated documentation and fixed broken font export mode for fontCreator.py
Also fixed broken modes for fontCreator and quotesSpreadsheetCreator scripts
Requiring python to be in env variables

This should be more portable (there's an error message if the python in env is not 2.7)
Versions supported are English, German, French, Italian and Spanish

More work would be required for Russian versions to be supported by the spreadsheet creator.
I don't have access to the Russian version that ScummVM currently supports/in the detection table.
Current implementation could be improved (to do away with all the if clauses for the glyph "exceptions")
but this is not high priority.
Also a small fix for the help mode of quoteSpreadsheetCreator tool
All scripts got better info and debug messages.

Also improved the --trace switch for all scripts and fixed some code formatting issues.
mixResourceCreator now additionally supports ITA, FRA, ESP, GER
All game language versions have the English VQA for the logo videos

Do not append the localization suffix to those two, but use the '_E' suffix instead.
In Spanish version the 'Designers Cut' translated option overlapped with Subtitles option
Blade Runner uses IBM437 encoding for its TRx resources

This covers the ENG, FRA, DEU, ITA and ESP versions.
The ERRORMSG.TRx use different encoding (Latin-1) but with a few bugs (a few character encoded with IBM437)
More work would probably be required for the RUS version.
Now we should specify target encoding per used font

If an encoding is not specified in configureFontsTraslation.txt, the default is used
quoteSpreadsheetCreator exports dev commentary and some optional speech audio from SFX.MIX
@antoniou79 antoniou79 changed the title DEVTOOLS: semi-auto creation of SUBTITLES.MIX DEVTOOLS: semi-auto creation of SUBTITLES.MIX for Blade Runner Jan 6, 2019
@antoniou79
Copy link
Contributor Author

I've tested a bit with localized versions of the game, namely DE, ITA, FR, ES.
The English subtitles for these versions work ok. For localized subtitles (in Deutsch, Italian, French, Español respectively) another font PNG would be needed; I'm thinking a charset like Windows-1252 would fit the requirements of all these translations probably.

Some notes and observations:

  • Speech that may be a placeholder in the English version (see the quotes marked as (boop) in the Excel) can be potentially used by a localized version. I've noticed this once, but it probably happens more often. For example the blimp guy's quote 60 (60-0030.AUD) is a "boop" sound in English, but there is voice-over in Italian.
  • Some quote slots that are used in the English version may be muted in other localized versions. For example, during McCoy's initial speech, when the game starts, the last line "No self-respecting human..." (99-1860.AUD) is muted and shortened in the Deutsch version.
  • The localized versions seem to also have voice-overs for the missing / removed dialogues as in the English one. A more thorough check would be needed, but it all seems to be there. Just mentioning this in case there's a plan to restore those -- especially since the Designers Cut mode barely does anything (or it could be another KIA option entirely).
  • The "dialogue" that exist in the SFX.MIX don't seem to be localized. This is mainly the 3 audio files with developer commentary (MA04VO1A.AUD, CT01VO1A.AUD, HC01VO1A.AUD) and a Blimp Guy talking ("COLONY.AUD"), as far as I know.

I haven't tested with the Russian version. I don't know the language at all and have no access to the supported Russian version of the game. Can anyone who owns it confirm that the version conforms to the naming convention for the files (eg are the Text Resource files named *.TRR ?). Creating a PNG for the Russian subtitles font would not be difficult though, and I also expect that the English subtitles would work as they are with the font image provided in the sampleInput folder.

@sev-
Copy link
Member

sev- commented Jan 6, 2019

I own the Russian version. Where to look? Inside the MIX files?

@antoniou79
Copy link
Contributor Author

I own the Russian version. Where to look? Inside the MIX files?

Yes, STARTUP.MIX would do.

@@ -14,9 +14,9 @@ DEVTOOLS := \
devtools/md5table$(EXEEXT) \
devtools/make-scumm-fontdata$(EXEEXT)

include $(srcdir)/devtools/*/module.mk
include $(srcdir)/devtools/*/module.mk $(srcdir)/devtools/*/*/module.mk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change. Rather do the following:

add module.mk to devtools/create_bladerunner, which will contain include directive. Test it and then I'll merge

@sev-
Copy link
Member

sev- commented Jan 6, 2019

The language files are named *.TRE, and contain Russian text in CP-1251 encoding. Apparently, English version was used as the base for the translation.

Changes in devtools/module.mk were reverted
@sev-
Copy link
Member

sev- commented Jan 6, 2019

Thanks! Merging, and welcome to the team!

@sev- sev- merged commit b254618 into scummvm:master Jan 6, 2019
ccawley2011 pushed a commit to ccawley2011/scummvm that referenced this pull request Oct 10, 2020
STARK: Enable rough confirmation dialogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants