Fix cast from const by accessing string data directly (#8354)

rubenwardy · nerzhul · commit 38f6e7a1981a · 2019-03-12T08:58:02.000+01:00
Fixes #8327
diff --git a/src/irrlicht_changes/irrUString.h b/src/irrlicht_changes/irrUString.h
@@ -2916,13 +2916,13 @@ class ustring16
 				ret[0] = unicode::BOM;
 			else if (endian == unicode::EUTFEE_LITTLE)
 			{
-				uchar8_t* ptr8 = reinterpret_cast<uchar8_t*>(ret.c_str());
+				uchar8_t* ptr8 = reinterpret_cast<uchar8_t*>(&ret[0]);
 				*ptr8++ = unicode::BOM_ENCODE_UTF16_LE[0];
 				*ptr8 = unicode::BOM_ENCODE_UTF16_LE[1];
 			}
 			else
 			{
-				uchar8_t* ptr8 = reinterpret_cast<uchar8_t*>(ret.c_str());
+				uchar8_t* ptr8 = reinterpret_cast<uchar8_t*>(&ret[0]);
 				*ptr8++ = unicode::BOM_ENCODE_UTF16_BE[0];
 				*ptr8 = unicode::BOM_ENCODE_UTF16_BE[1];
 			}

Original file line number	Diff line number	Diff line change
`@@ -2916,13 +2916,13 @@ class ustring16`
`2916`	`2916`	`ret[0] = unicode::BOM;`
`2917`	`2917`	`else if (endian == unicode::EUTFEE_LITTLE)`
`2918`	`2918`	`{`
`2919`		`- uchar8_t* ptr8 = reinterpret_cast<uchar8_t*>(ret.c_str());`
	`2919`	`+ uchar8_t* ptr8 = reinterpret_cast<uchar8_t*>(&ret[0]);`
`2920`	`2920`	`*ptr8++ = unicode::BOM_ENCODE_UTF16_LE[0];`
`2921`	`2921`	`*ptr8 = unicode::BOM_ENCODE_UTF16_LE[1];`
`2922`	`2922`	`}`
`2923`	`2923`	`else`
`2924`	`2924`	`{`
`2925`		`- uchar8_t* ptr8 = reinterpret_cast<uchar8_t*>(ret.c_str());`
	`2925`	`+ uchar8_t* ptr8 = reinterpret_cast<uchar8_t*>(&ret[0]);`
`2926`	`2926`	`*ptr8++ = unicode::BOM_ENCODE_UTF16_BE[0];`
`2927`	`2927`	`*ptr8 = unicode::BOM_ENCODE_UTF16_BE[1];`
`2928`	`2928`	`}`