tds_fdw: init a 1.0.8 #57465
Merged
tds_fdw: init a 1.0.8 #57465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
requested changes
Mar 12, 2019
| { stdenv, fetchFromGitHub, postgresql, freetds }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "tds_fdw-${version}"; |
There was a problem hiding this comment.
name will automatically be generated if you do:
Suggested change
| name = "tds_fdw-${version}"; | |
| pname = "tds_fdw"; |
|
|
||
| src = fetchFromGitHub { | ||
| owner = "tds-fdw"; | ||
| repo = "tds_fdw"; |
There was a problem hiding this comment.
Suggested change
| repo = "tds_fdw"; | |
| repo = pname; |
|
@GrahamcOfBorg build tds_fdw builds fine for me on NixOS. |
|
@GrahamcOfBorg build postgresqlPackages.tds_fdw |
|
Thank you @ryantm. Suggestion applied. |
ryantm
approved these changes
Mar 13, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Need to access Sql Server using PostgreSQL foreign data wrappers. This is possible thanks to https://github.com/tds-fdw/tds_fdw/
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)