Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.zeep: 3.2.0 -> 3.3.0 #57469

Merged
merged 3 commits into from Apr 11, 2019
Merged

python37Packages.zeep: 3.2.0 -> 3.3.0 #57469

merged 3 commits into from Apr 11, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-zeep/versions.

meta.description for python37Packages.zeep is: '"A modern/fast Python SOAP client based on lxml / requests"'.

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python27Packages.zeep
python37Packages.zeep

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/qi0vdy0wqw29zld6qhgxrqkmsdy5dv7n-python3.7-zeep-3.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A python37Packages.zeep https://github.com/r-ryantm/nixpkgs/archive/a110fdf216637bc27d3787745e4055d4a3c3e46f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qi0vdy0wqw29zld6qhgxrqkmsdy5dv7n-python3.7-zeep-3.3.0
ls -la /nix/store/qi0vdy0wqw29zld6qhgxrqkmsdy5dv7n-python3.7-zeep-3.3.0/bin

cc @rvl for testing.

@r-ryantm
python37Packages.zeep: 3.2.0 -> 3.3.0
a110fdf 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/python3.7-zeep/versions
@r-ryantm r-ryantm requested a review from FRidh as a code owner March 11, 2019 23:35
rvl
rvl approved these changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and module can be imported.
I couldn't easily find a real SOAP service to test with, because the example from the docs has gone offline.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.zeep

All of the Python 2 version's tests fail. @rvl Would you mind making a PR that makes the package use pytest_3 and also enables the tests on Python 3?

@rvl rvl mentioned this pull request Mar 23, 2019
Closed
10 tasks
@rvl
Copy link
Contributor

rvl commented Mar 23, 2019

@dotlambda Oh thanks, I read doCheck = !isPy3k the wrong way.

Happy to find out that pytest finally works on Python 3. The PR to enable that is #58154.

Python 2 is not going to work because the new dependencies don't support it.

@dotlambda
Copy link
Member

Happy to find out that pytest finally works on Python 3.

pytest_3 is not related to Python 3. It's just version 3 of pytest. Some packages are not compatible with version 4.

@dotlambda
Copy link
Member

Python 2 is not going to work because the new dependencies don't support it.

The new dependencies should be added only if we're on Python 3.

@rvl
Copy link
Contributor

rvl commented Mar 23, 2019

@dotlambda Zeep is not compatible with pytest 4 and I have no need for python 2.7 support.

@dotlambda
Copy link
Member

I have no need for python 2.7 support.

You're not the only being on this planet.

xeji
xeji suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix build for python2.

@dotlambda dotlambda merged commit 5908a02 into NixOS:master Apr 11, 2019
@r-ryantm r-ryantm deleted the auto-update/python3.7-zeep branch April 14, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji requested changes

@rvl rvl rvl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r-ryantm @dotlambda @rvl @xeji @infinisil @GrahamcOfBorg