Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scribus: 1.4.7 -> 1.4.8, dep fixups #57359

Merged
merged 1 commit into from Apr 10, 2019
Merged

scribus: 1.4.7 -> 1.4.8, dep fixups #57359

merged 1 commit into from Apr 10, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 11, 2019

Motivation for this change
  • Needs hunspell not aspell, not sure when
  • bake in gs path to avoid warning on launch
  • python-pillow for print preview, per README

https://www.scribus.net/scribus-1-4-8-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
scribus: 1.4.7 -> 1.4.8, dep fixups
e3e0f79 
* Needs hunspell not aspell, not sure when
* bake in gs path to avoid warning on launch
* python-pillow for print preview, per README

https://www.scribus.net/scribus-1-4-8-released/
@dtzWill
Copy link
Member Author

dtzWill commented Mar 17, 2019

@GrahamcOfBorg build scribus

@zookatron
Copy link
Contributor

I tested this change out on x86_64-linux in a KDE environment, and it builds and runs without any issues for me. 👍

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/17

@ryantm ryantm merged commit 2b37750 into NixOS:master Apr 10, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Apr 15, 2019

Thanks!

@dtzWill dtzWill deleted the update/scribus-1.4.8 branch April 15, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @zookatron @nixos-discourse @ryantm @infinisil @GrahamcOfBorg