Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pius: fix dependencies #57386

Merged
merged 1 commit into from Mar 14, 2019
Merged

pius: fix dependencies #57386

merged 1 commit into from Mar 14, 2019

Conversation

kierdavis
Copy link
Contributor

@kierdavis kierdavis commented Mar 11, 2019 •
edited

perl needs to be a native build input to ensure that it is
present in PATH during the build, allowing patchShebangs to
correctly fix the shebang in pius-party-worksheet. Previously,
the shebang was left as /usr/bin/perl because perl could not
be found by patchShebangs.

six is a required dependency of pius and likely should have
been included in the derivation a long time ago, since the pius,
pius-report and pius-keyring-mgr commands are broken without it.
Annoyingly, pius still uses distutils rather than setuptools
which seems to happily install the package without checking that
its dependencies have been installed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Before 344407416, after 398863960, difference +54456544
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kierdavis
pius: fix dependencies
d700803 
`perl` needs to be a native build input to ensure that it is
present in `PATH` during the build, allowing `patchShebangs` to
correctly fix the shebang in `pius-party-worksheet`. Previously,
the shebang was left as `/usr/bin/perl` because `perl` could not
be found by `patchShebangs`.

`six` is a required dependency of `pius` and likely should have
been included in the derivation a long time ago, since the `pius`,
`pius-report` and `pius-keyring-mgr` commands are broken without it.
Annoyingly, `pius` still uses `distutils` rather than `setuptools`
which seems to happily install the package without checking that
its dependencies have been installed.
@kierdavis kierdavis mentioned this pull request Mar 11, 2019
Merged
@ryantm
Copy link
Member

ryantm commented Mar 12, 2019

@GrahamcOfBorg build pius

@ryantm
Copy link
Member

ryantm commented Mar 14, 2019

@GrahamcOfBorg build pius

@ryantm ryantm merged commit e20ee8a into NixOS:master Mar 14, 2019
@ryantm
Copy link
Member

ryantm commented Mar 14, 2019

thanks!

@kierdavis kierdavis deleted the pius-fix-dependencies branch March 14, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kierdavis @ryantm @GrahamcOfBorg