Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musly: init at unstable-2017-04-26 #57389

Merged
merged 3 commits into from Mar 22, 2019
Merged

musly: init at unstable-2017-04-26 #57389

merged 3 commits into from Mar 22, 2019

Conversation

ggPeti
Copy link
Member

@ggPeti ggPeti commented Mar 11, 2019 •
edited

Motivation for this change

Musly is a fast and effective open source audio similarity tool.
This package is also the first time it's ported to macOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

etu
etu reviewed Mar 12, 2019
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/audio/musly/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/musly/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/musly/default.nix Show resolved Hide resolved
pkgs/applications/audio/musly/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/musly/default.nix Outdated Show resolved Hide resolved
@grahamc grahamc requested a review from etu March 14, 2019 16:12
@etu
Copy link
Contributor

etu commented Mar 14, 2019

@ggPeti We'd also prefer if you squash your commits with the license fix.

@GrahamcOfBorg build musly

jtojnar
jtojnar requested changes Mar 15, 2019
View reviewed changes
pkgs/applications/audio/musly/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/musly/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/musly/default.nix Show resolved Hide resolved
@ggPeti ggPeti changed the title musly: init at 0.2 musly: init at unstable-2017-04-26 Mar 20, 2019
@ggPeti
Copy link
Member Author

ggPeti commented Mar 20, 2019

@jtojnar @etu pls approve

@etu
Copy link
Contributor

etu commented Mar 20, 2019

@GrahamcOfBorg build musly

@ggPeti
Copy link
Member Author

ggPeti commented Mar 20, 2019

I'm not sure why the checks say "No attempt" - am I still doing something wrong?

@jtojnar @ggPeti
musly: fix platforms
e3521e9 
Co-Authored-By: ggPeti <ggpeti@gmail.com>
@etu
Copy link
Contributor

etu commented Mar 21, 2019

@GrahamcOfBorg build musly

@ggPeti
Copy link
Member Author

ggPeti commented Mar 21, 2019

Everything seems to be fine

@brainrake
Copy link
Contributor

brainrake commented Mar 21, 2019 •
edited

Built it, ran it. Looks like it works.

@etu etu merged commit 870db5e into NixOS:master Mar 22, 2019
@etu
Copy link
Contributor

etu commented Mar 22, 2019

@ggPeti Thank you very much for your contribution and patient to get everything together :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ggPeti @etu @brainrake @jtojnar @GrahamcOfBorg