Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 1.0.1 -> 1.1.0 #57364

Merged
merged 1 commit into from Mar 12, 2019
Merged

syncthing: 1.0.1 -> 1.1.0 #57364

merged 1 commit into from Mar 12, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 11, 2019

Motivation for this change

Closes #57170

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp
Copy link
Member

bachp commented Mar 11, 2019 •
edited

I get:

hash mismatch in fixed-output derivation '/nix/store/ir6mad47zs8kh3h1r3vdfkiq7b6w75d6-geoip2-golang':
  wanted: sha256:0v698bzs8lb59cqpsa9cf4sl8rdsvnnmaravhbfn6g6i511ppclr
  got:    sha256:10pvjmbm1wc8xxwqlcfhdj2mciiyfddghmp6jyn7brd4mg65ppy2

and:

hash mismatch in fixed-output derivation '/nix/store/1rds9w66wr2rg23rf7kpl5y17rbybfh8-maxminddb-golang-26fe5ac':
  wanted: sha256:1i6d935f3cv9djpjvc2ibh8aps8jqvg454b9pkwg2h98al759ggk
  got:    sha256:0szb96zq1jbd9zpf4qn9zng4582ww9mg8zgrqxbkkpf3862r6n49

After manually fixing those two hashes it builds.

xeji
xeji suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update deps.nix to fix hash mismatches

@marsam
Copy link
Contributor Author

marsam commented Mar 11, 2019

that is odd, I get the same hashes with nix-prefetch-git

$ nix-prefetch-git https://github.com/oschwald/geoip2-golang --rev v1.1.0 2>/dev/null
{
  "url": "https://github.com/oschwald/geoip2-golang",
  "rev": "5b1dc16861f81d05d9836bb21c2d0d65282fc0b8",
  "date": "2017-04-23T14:58:58-07:00",
  "sha256": "0v698bzs8lb59cqpsa9cf4sl8rdsvnnmaravhbfn6g6i511ppclr",
  "fetchSubmodules": false
}

$ nix-prefetch-git https://github.com/oschwald/maxminddb-golang --rev 26fe5ace1c70 2>/dev/null
{
  "url": "https://github.com/oschwald/maxminddb-golang",
  "rev": "26fe5ace1c706491c2936119e1dc69c1a9c04d7f",
  "date": "2017-09-01T06:40:56-07:00",
  "sha256": "1i6d935f3cv9djpjvc2ibh8aps8jqvg454b9pkwg2h98al759ggk",
  "fetchSubmodules": false
}

@xeji
Copy link
Contributor

xeji commented Mar 11, 2019

I ran nix-build ~/nixpkgs -A syncthing on my local checkout of this PR branch as usual without prefetching, and got the same hash mismatches as @bachp. x86_64-linux here.

I recall seeing similar issues in the past which turned out to be caused by differences of macOS vs linux file systems (case-sensitive vs. non-case-sensitive). Could this be the cause here? If you have access to both a mac and a linux box you can have a look...

@marsam
Copy link
Contributor Author

marsam commented Mar 12, 2019

Fixed. it happened because vgo2nix called nix-prefetch-git without the --fetch-submodules flag nix-community/vgo2nix@c3cf055

@xeji
Copy link
Contributor

xeji commented Mar 12, 2019

Thank you!
@GrahamcOfBorg build syncthing

@xeji xeji merged commit ea0e914 into NixOS:master Mar 12, 2019
@marsam marsam deleted the update-syncthing branch March 12, 2019 21:21
peterhoeg pushed a commit to peterhoeg/nixpkgs that referenced this pull request Jun 13, 2019
@marsam @peterhoeg
syncthing: 1.0.1 -> 1.1.0 (NixOS#57364)
adfdc4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @bachp @xeji @GrahamcOfBorg