Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sway 1.0 #57405

Closed
wants to merge 6 commits into from
Closed

Sway 1.0 #57405

wants to merge 6 commits into from
+58 −188

Conversation

tadeokondrak
Copy link
Contributor

@tadeokondrak tadeokondrak commented Mar 11, 2019 •
edited
Loading

Motivation for this change

Sway is out of beta

This PR removes sway-beta and replaces the main sway package with sway 1.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@tadeokondrak tadeokondrak force-pushed the sway-1.0 branch 2 times, most recently from 0d45b15 to 0fdfefa Compare March 11, 2019 15:55
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up labels Mar 11, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from primeos March 11, 2019 16:13
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 11, 2019
@tadeokondrak
sway-beta: remove
ebd387c 
removed in favour of main sway package, which is now 1.0
@tadeokondrak
nixos/sway: update to support sway 1.0
769aa6c 
removes old module and replaces it with sway-beta
@tadeokondrak
nixos/sway-beta: remove
555a874 
removed in favour of the main sway module which is now out of beta
@tadeokondrak
nixos/sway: add padding whitespace
a454b4d 
This commit is mostly to try to let github let me mark my PR as ready to
review, because there's no button to do that and I think it doesn't
update on force pushes.
@tadeokondrak
Copy link
Contributor Author

Re-making PR with just modules, since stuff is conflicting and I'm in git hell

@tadeokondrak tadeokondrak deleted the sway-1.0 branch March 11, 2019 16:29
@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tadeokondrak @GrahamcOfBorg